Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: check plugin name on plugin_reload rpc call (backport of #33582) #34668

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 5, 2024

This is an automatic backport of pull request #33582 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* check plugin name on plugin_reload rpc call

* add name to error message

(cherry picked from commit 808f67a)
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9c09b16) 81.7% compared to head (e7bf2d0) 81.7%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34668     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         805      805             
  Lines      218635   218642      +7     
=========================================
- Hits       178785   178780      -5     
- Misses      39850    39862     +12     

@willhickey
Copy link
Contributor

We can't backport this to beta at this point in the stabilization cycle...

The master version of this has run on canaries but not on a whole cluster. Since beta will be promoted to stable soon, backporting this to beta will ship it to mainnet-beta very quickly with minimal time to test on testnet.

@lijunwangs
Copy link
Contributor

We can't backport this to beta at this point in the stabilization cycle...

The master version of this has run on canaries but not on a whole cluster. Since beta will be promoted to stable soon, backporting this to beta will ship it to mainnet-beta very quickly with minimal time to test on testnet.

The change/risk is minimal and only impact geyser plugin reload workflow.

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tepid about this backport, but I guess it's okay.

@lijunwangs lijunwangs merged commit 6af8e3b into v1.17 Jan 10, 2024
33 checks passed
@lijunwangs lijunwangs deleted the mergify/bp/v1.17/pr-33582 branch January 10, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants